Re: Patch "crypto: qat - do not export adf_iov_putmsg()" has been added to the 4.4-stable tree
From: Greg KH
Date: Mon Sep 13 2021 - 03:50:42 EST
On Sun, Sep 12, 2021 at 11:23:05PM -0400, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
>
> crypto: qat - do not export adf_iov_putmsg()
>
> to the 4.4-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> crypto-qat-do-not-export-adf_iov_putmsg.patch
> and it can be found in the queue-4.4 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
>
>
>
> commit 5f8033f94420950b5fc4b91dd2154c00fc88d44e
> Author: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>
> Date: Thu Aug 12 21:21:28 2021 +0100
>
> crypto: qat - do not export adf_iov_putmsg()
>
> [ Upstream commit 645ae0af1840199086c33e4f841892ebee73f615 ]
>
> The function adf_iov_putmsg() is only used inside the intel_qat module
> therefore should not be exported.
> Remove EXPORT_SYMBOL for the function adf_iov_putmsg().
>
> Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>
> Reviewed-by: Fiona Trahe <fiona.trahe@xxxxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> diff --git a/drivers/crypto/qat/qat_common/adf_pf2vf_msg.c b/drivers/crypto/qat/qat_common/adf_pf2vf_msg.c
> index 711706819b05..f071aba32a28 100644
> --- a/drivers/crypto/qat/qat_common/adf_pf2vf_msg.c
> +++ b/drivers/crypto/qat/qat_common/adf_pf2vf_msg.c
> @@ -254,7 +254,6 @@ int adf_iov_putmsg(struct adf_accel_dev *accel_dev, u32 msg, u8 vf_nr)
>
> return ret;
> }
> -EXPORT_SYMBOL_GPL(adf_iov_putmsg);
>
> void adf_vf2pf_req_hndl(struct adf_accel_vf_info *vf_info)
> {
This breaks the build on the 4.4.y stable queue, so I am dropping it
from there.
thanks,
greg k-h