Re: [PATCH] trace: Do some cleanups for osnoise tracer

From: kernel test robot
Date: Mon Sep 13 2021 - 04:54:39 EST


Hi Tang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/perf/core]
[also build test WARNING on v5.15-rc1 next-20210913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Tang-Yizhou/trace-Do-some-cleanups-for-osnoise-tracer/20210913-111459
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4034fb207e302cc0b1f304084d379640c1fb1436
config: i386-randconfig-s001-20210912 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/cecf38d3b5e23a411856f6c8f3e3be903e439876
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tang-Yizhou/trace-Do-some-cleanups-for-osnoise-tracer/20210913-111459
git checkout cecf38d3b5e23a411856f6c8f3e3be903e439876
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)
>> kernel/trace/trace_osnoise.c:1826:20: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected unsigned long long [usertype] *max @@ got unsigned long long const * @@
kernel/trace/trace_osnoise.c:1826:20: sparse: expected unsigned long long [usertype] *max
kernel/trace/trace_osnoise.c:1826:20: sparse: got unsigned long long const *
>> kernel/trace/trace_osnoise.c:1827:20: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected unsigned long long [usertype] *min @@ got unsigned long long const * @@
kernel/trace/trace_osnoise.c:1827:20: sparse: expected unsigned long long [usertype] *min
kernel/trace/trace_osnoise.c:1827:20: sparse: got unsigned long long const *

vim +1826 kernel/trace/trace_osnoise.c

a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1817
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1818 /*
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1819 * osnoise/timerlat_period: min 100 us, max 1 s
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1820 */
cecf38d3b5e23a41 Tang Yizhou 2021-09-13 1821 static const u64 timerlat_min_period = 100;
cecf38d3b5e23a41 Tang Yizhou 2021-09-13 1822 static const u64 timerlat_max_period = 1000000;
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1823 static struct trace_min_max_param timerlat_period = {
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1824 .lock = &interface_lock,
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1825 .val = &osnoise_data.timerlat_period,
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 @1826 .max = &timerlat_max_period,
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 @1827 .min = &timerlat_min_period,
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1828 };
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1829 #endif
a955d7eac1779b43 Daniel Bristot de Oliveira 2021-06-22 1830

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip