[PATCH v3 07/32] staging: wfx: fix atomic accesses in wfx_tx_queue_empty()

From: Jerome Pouiller
Date: Mon Sep 13 2021 - 09:05:17 EST


From: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>

Checking if a skb_queue is empty is not an atomic operation. We should
take some precautions to do it.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
---
drivers/staging/wfx/queue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
index 31c37f69c295..fa272c120f1c 100644
--- a/drivers/staging/wfx/queue.c
+++ b/drivers/staging/wfx/queue.c
@@ -86,7 +86,8 @@ void wfx_tx_queues_check_empty(struct wfx_vif *wvif)

bool wfx_tx_queue_empty(struct wfx_vif *wvif, struct wfx_queue *queue)
{
- return skb_queue_empty(&queue->normal) && skb_queue_empty(&queue->cab);
+ return skb_queue_empty_lockless(&queue->normal) &&
+ skb_queue_empty_lockless(&queue->cab);
}

static void __wfx_tx_queue_drop(struct wfx_vif *wvif,
--
2.33.0