Re: sound/isa/es1688/es1688_lib.c:384:79: error: 'DMA_AUTOINIT' undeclared

From: Arnd Bergmann
Date: Mon Sep 13 2021 - 09:54:22 EST


On Mon, Sep 13, 2021 at 9:55 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> > CONFIG_ISA_DMA_API=y
> > but CONFIG_ISA is not set.
> > (Yes, this is ColdFire.)
> >
> > menuconfig SND_ISA
> > bool "ISA sound devices"
> > depends on ISA || COMPILE_TEST
> > depends on ISA_DMA_API
> > default y
> >
> > I suppose that we could drop the "|| COMPILE_TEST" part.
>
> Or "... || (COMPILE_TEST && !M68K)"?

I think both approaches still fail for Q40 and AMIGA_PCMCIA,
which also set CONFIG_ISA, but still don't provide that
symbol.

AFAICT, we instead need

depends on ISA_DMA_API && !M68K

The COMPILE_TEST can stay then, though it would
not be a huge loss to remove that.

Arnd