Re: [PATCH] media: atomisp: fix control reaches end of non-void function error

[Shuah Khan]

On 9/13/21 2:41 AM, Dan Carpenter wrote:
> On Fri, Sep 10, 2021 at 04:37:00PM -0600, Shuah Khan wrote:
> > Fix the following build error with -Werror=return-type enabled. Fix
> > input_system_configure_channel_sensor() to return status when control
> > reaches the end.
> >
> > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o
> > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
> > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> >   1649 | }
> >
> > Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
>
> Hi Shuah,
>
> You're the third person to send this patch recently but it was fixed on
> Aug 2 in staging-next in commit 05344a1d2ea7 ("media: atomisp: restore
> missing 'return' statement").  What tree are you working against?  It
> seems like it needs to be backported somewhere.

I am working on Linux 5.15 - should have checked staging next though before
sending the patch :)

thanks,
-- Shuah