Re: [PATCH][next] fs/ntfs3: Remove redundant initialization of variable err

From: Konstantin Komarov
Date: Mon Sep 13 2021 - 12:49:56 EST




On 03.09.2021 16:24, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable err is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> fs/ntfs3/index.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 0daca9adc54c..b1175542d854 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1401,7 +1401,7 @@ int indx_find_raw(struct ntfs_index *indx, struct ntfs_inode *ni,
> static int indx_create_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
> CLST *vbn)
> {
> - int err = -ENOMEM;
> + int err;
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> struct ATTRIB *bitmap;
> struct ATTRIB *alloc;
>

Hi Colin, thanks for the patch - applied it.

Best regards.