Re: [RFC PATCH net] Revert "net: phy: Uniform PHY driver access"

From: Andrew Lunn
Date: Mon Sep 13 2021 - 14:49:34 EST


> I am not sure why "to_phy_driver" needs cleanup. Au contraire, I think
> the PHY library's usage of struct phy_device :: drv is what is strange
> and potentially buggy, it is the only subsystem I know of that keeps its
> own driver pointer rather than looking at struct device :: driver.

There is one odd driver in the mix. Take a look at xilinx_gmii2rgmii.c.

It probably could be done a better way, but that is what we have.

Andrew