Re: [PATCH 1/2] drm/bridge: parade-ps8640: Use regmap APIs
From: Philip Chen
Date: Mon Sep 13 2021 - 17:36:58 EST
On Thu, Sep 9, 2021 at 2:27 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
> Quoting Doug Anderson (2021-09-09 14:14:29)
> > On Thu, Sep 9, 2021 at 12:09 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> > >
> > >
> > > Oh does this have register pages? regmap has support for pages where you
> > > write some indirection register and then access the same i2c address for
> > > the next page. This looks different though and has a different i2c
> > > address for each page?
> >
> > I haven't looked in tons of detail, but I think the right solution
> > here is a separate regmap config per page.
>
> Yes. And then a different .max_register value for each config struct. A
> different .name might be useful to indicate which page it is too.
I see.
I posted v2 with the fix for this.
PTAL.