Re: [PATCH v2] scsi: bsg: Fix device unregistration
From: Martin K. Petersen
Date: Tue Sep 14 2021 - 00:41:11 EST
On Sat, 11 Sep 2021 18:53:06 +0800, Zenghui Yu wrote:
> We use device_initialize() to take refcount for the device but forget to
> put_device() on device teardown, which ends up leaking private data of the
> driver core, dev_name(), etc. This is reported by kmemleak at boot time if
> we compile kernel with DEBUG_TEST_DRIVER_REMOVE.
>
> Note that adding the missing put_device() is _not_ sufficient to fix device
> unregistration. As we don't provide the .release() method for device, which
> turned out to be typically wrong and will be complained loudly by the
> driver core.
>
> [...]
Applied to 5.15/scsi-fixes, thanks!
[1/1] scsi: bsg: Fix device unregistration
https://git.kernel.org/mkp/scsi/c/1a0db7744e45
--
Martin K. Petersen Oracle Linux Engineering