Re: [PATCH RESEND v3 10/13] blk-mq: Add blk_mq_alloc_map_and_rqs()

[Hannes Reinecke]

On 9/13/21 5:12 PM, John Garry wrote:
> Add a function to combine allocating tags and the associated requests,
> and factor out common patterns to use this new function.
>
> Some functions only call blk_mq_alloc_map_and_rqs() now, but more
> functionality will be added later to those functions.
>
> Also make blk_mq_alloc_rq_map() and blk_mq_alloc_rqs() static since they
> are only used in blk-mq.c, and finally rename some functions for
> conciseness and consistency with other function names:
> - __blk_mq_alloc_map_and_{request -> rqs}()
> - blk_mq_alloc_{map_and_requests -> set_map_and_rqs}()
>
> Suggested-by: Ming Lei <ming.lei@xxxxxxxxxx>
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
>   block/blk-mq-sched.c | 15 +++--------
>   block/blk-mq-tag.c   |  9 +------
>   block/blk-mq.c       | 62 +++++++++++++++++++++++++-------------------
>   block/blk-mq.h       |  9 ++-----
>   4 files changed, 42 insertions(+), 53 deletions(-)
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer