Re: [PATCH RESEND v3 13/13] blk-mq: Stop using pointers for blk_mq_tags bitmap tags

[Hannes Reinecke]

On 9/13/21 5:12 PM, John Garry wrote:
> Now that we use shared tags for shared sbitmap support, we don't require
> the tags sbitmap pointers, so drop them.
>
> This essentially reverts commit 222a5ae03cdd ("blk-mq: Use pointers for
> blk_mq_tags bitmap tags").
>
> Function blk_mq_init_bitmap_tags() is removed also, since it would be only
> a wrappper for blk_mq_init_bitmaps().
>
> Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
>   block/bfq-iosched.c    |  4 +--
>   block/blk-mq-debugfs.c |  8 +++---
>   block/blk-mq-tag.c     | 56 +++++++++++++++---------------------------
>   block/blk-mq-tag.h     |  7 ++----
>   block/blk-mq.c         |  8 +++---
>   block/kyber-iosched.c  |  4 +--
>   block/mq-deadline.c    |  2 +-
>   7 files changed, 35 insertions(+), 54 deletions(-)
> A round of silent applause :-)

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer