Re: [RFC 01/19] dt-bindings: interconnect: imx8mq: Add missing pl301 and SAI ids

[Georgi Djakov]

Hi Abel,

On 13.09.21 20:37, Abel Vesa wrote:
> According to the bus diagram, there are two more pl301s that need to
> be added here. The pl301_per_m which is an intermediary node between
> pl301_main and its masters: usdhc1, usdhc2 and sdma. The pl301_wakeup
> is an intermediary node between pl301_main and its masters, in this case
> all the SAIs.

Thanks for working on this!

> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> ---
>   include/dt-bindings/interconnect/imx8mq.h | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/include/dt-bindings/interconnect/imx8mq.h b/include/dt-bindings/interconnect/imx8mq.h
> index 1a4cae7f8be2..1953de8af5cb 100644
> --- a/include/dt-bindings/interconnect/imx8mq.h
> +++ b/include/dt-bindings/interconnect/imx8mq.h
> @@ -44,5 +44,14 @@
>   #define IMX8MQ_ICM_PCIE1	26
>   #define IMX8MQ_ICM_PCIE2	27
>   #define IMX8MQ_ICN_MAIN		28
> +#define IMX8MQ_ICN_PER_M	30

Is there any reason to jump from 28 to 30?

Thanks,
Georgi

> +
> +#define IMX8MQ_ICN_WAKEUP	31
> +#define IMX8MQ_ICM_SAI1		32
> +#define IMX8MQ_ICM_SAI2		33
> +#define IMX8MQ_ICM_SAI3		34
> +#define IMX8MQ_ICM_SAI4		35
> +#define IMX8MQ_ICM_SAI5		36
> +#define IMX8MQ_ICM_SAI6		37
>   
>   #endif /* __DT_BINDINGS_INTERCONNECT_IMX8MQ_H */