Re: [PATCH v4 8/8] memory: gpmc-omap: "gpmc,device-width" DT property is optional

From: Roger Quadros
Date: Wed Sep 15 2021 - 04:47:46 EST


Hi Krzysztof,

On 15/09/2021 10:12, Krzysztof Kozlowski wrote:
> On 14/09/2021 14:27, Roger Quadros wrote:
>> Check for valid gpmc,device-width, nand-bus-width and bank-width
>> at one place. Default to 8-bit width if none present.
>>
>> Signed-off-by: Roger Quadros <rogerq@xxxxxxxxxx>
>> ---
>> drivers/memory/omap-gpmc.c | 41 ++++++++++++++++++++++++--------------
>> 1 file changed, 26 insertions(+), 15 deletions(-)
>>
>
> All the comments from v3 are still applicable because it seems you
> ignored them. Please respond to them.
>
> It's the second patch where the reviewer's comments got lost, so it
> creates rather poor impression.

I was wondering what comments and then realized that gmail server has put
all your messages into spam folder.

I'm very sorry about that. I will address your comments ASAP.

cheers,
-roger