Re: [PATCH 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e

[Michael Straube]

On 9/15/21 00:22, Phillip Potter wrote:
> On Tue, Sep 14, 2021 at 02:13:48PM +0200, Michael Straube wrote:
> > This series removes some unused fields from struct hal_data_8188eu.
> >
> > Tested on x86_64 with Inter-Tech DMG-02.
> >
> > Michael Straube (4):
> >    staging: r8188eu: remove unused macros from rtl8188e_hal.h
> >    staging: r8188eu: remove write-only fields from struct hal_data_8188e
> >    staging: r8188eu: remove unused enums from rtl8288e_hal.h
> >    staging: r8188eu: remove unused field from struct hal_data_8188e
> >
> >   .../staging/r8188eu/hal/rtl8188e_hal_init.c   |  5 -----
> >   .../staging/r8188eu/include/rtl8188e_hal.h    | 22 -------------------
> >   2 files changed, 27 deletions(-)
> >
> > --
> > 2.33.0
>
> Dear Michael,
>
> Looks good, built and tested here and working fine - as you say though
> these are removals of unused code/properties so I was expecting it to
> work anyway :-)
>
> One small thing to change though: the subject line of PATCH 3/4 should
> refer to rtl8188e_hal.h, rather than rtl8288e_hal.h.

Thank you for reviewing and spotting the typo Phillip.
I'll send v2 soon.

Regards,
Michael