Re: [PATCH v2 3/5] drivers/acpi: Introduce Platform Firmware Runtime Update device driver

[Chen Yu]

Hi Greg,
thank you very much for your comments,
On Tue, Sep 14, 2021 at 10:11:31AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 14, 2021 at 03:58:41PM +0800, Chen Yu wrote:
> > +enum start_action {
> > +	START_STAGE,
> > +	START_ACTIVATE,
> > +	START_STAGE_ACTIVATE,
> > +};
> > +
> > +enum dsm_status {
> > +	DSM_SUCCEED,
> > +	DSM_FUNC_NOT_SUPPORT,
> > +	DSM_INVAL_INPUT,
> > +	DSM_HARDWARE_ERR,
> > +	DSM_RETRY_SUGGESTED,
> > +	DSM_UNKNOWN,
> > +	DSM_FUNC_SPEC_ERR,
> > +};
> > +
> > +struct update_cap_info {
> > +	enum dsm_status status;
> > +	int update_cap;
> > +
> > +	uuid_t code_type;
> > +	int fw_version;
> > +	int code_rt_version;
> > +
> > +	uuid_t drv_type;
> > +	int drv_rt_version;
> > +	int drv_svn;
> > +
> > +	uuid_t platform_id;
> > +	uuid_t oem_id;
> > +
> > +	char oem_info[];
> 
> Please use valid types for structures that cross the user/kernel
> boundry.
> 
Okay, I'll switch them into __u prefixed one.
> > +};
> > +
> > +struct com_buf_info {
> > +	enum dsm_status status;
> > +	enum dsm_status ext_status;
> > +	unsigned long addr_lo;
> > +	unsigned long addr_hi;
> > +	int buf_size;
> > +};
> 
> Same here.
> 
Okay, I'll fix them.
> > +
> > +struct updated_result {
> > +	enum dsm_status status;
> > +	enum dsm_status ext_status;
> > +	unsigned long low_auth_time;
> > +	unsigned long high_auth_time;
> > +	unsigned long low_exec_time;
> > +	unsigned long high_exec_time;
> 
> And same here.
> 
> And these are very odd structure names that you are adding to the
> "global" namespace.  Please make them have a prefix for your driver so
> that people know what they belong to.  "updated_result" is way too
> generic.
> 
Okay, added the driver name prefix in next version.

thanks,
Chenyu