Re: [PATCH] nvme: add command id quirk for apple controllers
From: Jens Axboe
Date: Mon Sep 27 2021 - 11:39:34 EST
On 9/27/21 9:35 AM, Keith Busch wrote:
> @@ -1026,7 +1027,8 @@ blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req)
> return BLK_STS_IOERR;
> }
>
> - nvme_req(req)->genctr++;
> + if (!ctrl->quirks & NVME_QUIRK_SKIP_CID_GEN)
> + nvme_req(req)->genctr++;
This doesn't look right, as it'll never be true...
--
Jens Axboe