Re: [PATCH] nvme: add command id quirk for apple controllers

[kernel test robot]

Hi Keith,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.15-rc3 next-20210922]
[cannot apply to hch-configfs/for-next linux-nvme/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Keith-Busch/nvme-add-command-id-quirk-for-apple-controllers/20210929-191053
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a4e6f95a891ac08bd09d62e3e6dae239b150f4c1
config: hexagon-randconfig-r045-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c62c81f7de2ecd19bd3f85afe63d0040401bce0c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Keith-Busch/nvme-add-command-id-quirk-for-apple-controllers/20210929-191053
        git checkout c62c81f7de2ecd19bd3f85afe63d0040401bce0c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/nvme/host/core.c:1030:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
           if (!ctrl->quirks & NVME_QUIRK_SKIP_CID_GEN)
               ^             ~
   drivers/nvme/host/core.c:1030:6: note: add parentheses after the '!' to evaluate the bitwise operator first
           if (!ctrl->quirks & NVME_QUIRK_SKIP_CID_GEN)
               ^
                (                                     )
   drivers/nvme/host/core.c:1030:6: note: add parentheses around left hand side expression to silence this warning
           if (!ctrl->quirks & NVME_QUIRK_SKIP_CID_GEN)
               ^
               (            )
   1 warning generated.


vim +1030 drivers/nvme/host/core.c

   977	
   978	blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req)
   979	{
   980		struct nvme_command *cmd = nvme_req(req)->cmd;
   981		struct nvme_ctrl *ctrl = nvme_req(req)->ctrl;
   982		blk_status_t ret = BLK_STS_OK;
   983	
   984		if (!(req->rq_flags & RQF_DONTPREP)) {
   985			nvme_clear_nvme_request(req);
   986			memset(cmd, 0, sizeof(*cmd));
   987		}
   988	
   989		switch (req_op(req)) {
   990		case REQ_OP_DRV_IN:
   991		case REQ_OP_DRV_OUT:
   992			/* these are setup prior to execution in nvme_init_request() */
   993			break;
   994		case REQ_OP_FLUSH:
   995			nvme_setup_flush(ns, cmd);
   996			break;
   997		case REQ_OP_ZONE_RESET_ALL:
   998		case REQ_OP_ZONE_RESET:
   999			ret = nvme_setup_zone_mgmt_send(ns, req, cmd, NVME_ZONE_RESET);
  1000			break;
  1001		case REQ_OP_ZONE_OPEN:
  1002			ret = nvme_setup_zone_mgmt_send(ns, req, cmd, NVME_ZONE_OPEN);
  1003			break;
  1004		case REQ_OP_ZONE_CLOSE:
  1005			ret = nvme_setup_zone_mgmt_send(ns, req, cmd, NVME_ZONE_CLOSE);
  1006			break;
  1007		case REQ_OP_ZONE_FINISH:
  1008			ret = nvme_setup_zone_mgmt_send(ns, req, cmd, NVME_ZONE_FINISH);
  1009			break;
  1010		case REQ_OP_WRITE_ZEROES:
  1011			ret = nvme_setup_write_zeroes(ns, req, cmd);
  1012			break;
  1013		case REQ_OP_DISCARD:
  1014			ret = nvme_setup_discard(ns, req, cmd);
  1015			break;
  1016		case REQ_OP_READ:
  1017			ret = nvme_setup_rw(ns, req, cmd, nvme_cmd_read);
  1018			break;
  1019		case REQ_OP_WRITE:
  1020			ret = nvme_setup_rw(ns, req, cmd, nvme_cmd_write);
  1021			break;
  1022		case REQ_OP_ZONE_APPEND:
  1023			ret = nvme_setup_rw(ns, req, cmd, nvme_cmd_zone_append);
  1024			break;
  1025		default:
  1026			WARN_ON_ONCE(1);
  1027			return BLK_STS_IOERR;
  1028		}
  1029	
> 1030		if (!ctrl->quirks & NVME_QUIRK_SKIP_CID_GEN)
  1031			nvme_req(req)->genctr++;
  1032		cmd->common.command_id = nvme_cid(req);
  1033		trace_nvme_setup_cmd(req, cmd);
  1034		return ret;
  1035	}
  1036	EXPORT_SYMBOL_GPL(nvme_setup_cmd);
  1037	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip