Re: [PATCH -next] mmc: sdhci-omap: Remove forward declaration of sdhci_omap_context_save()

[Ulf Hansson]

On Wed, 20 Oct 2021 at 11:05, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> If CONFIG_PM_SLEEP=n:
>
>     drivers/mmc/host/sdhci-omap.c:1213:13: error: ‘sdhci_omap_context_save’ declared ‘static’ but never defined [-Werror=unused-function]
>      1213 | static void sdhci_omap_context_save(struct sdhci_omap_host *omap_host);
>           |             ^~~~~~~~~~~~~~~~~~~~~~~
>
> The referenced commit added an unrelated forward declaration of
> sdhci_omap_context_save(), which is unneeded in general, and unused when
> CONFIG_PM_SLEEP=n.
>
> Fixes: f433e8aac6b94218 ("mmc: sdhci-omap: Implement PM runtime functions")
> Reported-by: noreply@xxxxxxxxxxxxxx
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-omap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 0dec2f849b81e242..a4a1734dcb84e9cf 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -1210,8 +1210,6 @@ static const struct soc_device_attribute sdhci_omap_soc_devices[] = {
>         }
>  };
>
> -static void sdhci_omap_context_save(struct sdhci_omap_host *omap_host);
> -
>  static int sdhci_omap_probe(struct platform_device *pdev)
>  {
>         int ret;
> --
> 2.25.1
>