[ti:ti-linux-5.10.y 7172/9684] drivers/media/pci/intel/ipu3/ipu3-cio2.c:983:27: error: passing argument 1 of 'media_pipeline_start' from incompatible pointer type

From: kernel test robot
Date: Mon Oct 25 2021 - 16:49:23 EST


Hi Sakari,

FYI, the error/warning still remains.

tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.10.y
head: f22103162c771ddd47372b579682445e6dc8dd0e
commit: d42003cd0440e21c8940801e58ba2aabf3dc13b6 [7172/9684] media: entity: Use pad as the starting point for a pipeline
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-linux-5.10.y
git checkout d42003cd0440e21c8940801e58ba2aabf3dc13b6
# save the attached .config to linux build tree
make W=1 ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/media/pci/intel/ipu3/ipu3-cio2.c: In function 'cio2_vb2_start_streaming':
>> drivers/media/pci/intel/ipu3/ipu3-cio2.c:983:27: error: passing argument 1 of 'media_pipeline_start' from incompatible pointer type [-Werror=incompatible-pointer-types]
983 | r = media_pipeline_start(&q->vdev.entity, &q->pipe);
| ^~~~~~~~~~~~~~~
| |
| struct media_entity *
In file included from include/media/media-device.h:18,
from include/media/media-request.h:20,
from include/media/v4l2-ctrls.h:14,
from drivers/media/pci/intel/ipu3/ipu3-cio2.c:23:
include/media/media-entity.h:948:57: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
948 | __must_check int media_pipeline_start(struct media_pad *pad,
| ~~~~~~~~~~~~~~~~~~^~~
>> drivers/media/pci/intel/ipu3/ipu3-cio2.c:1003:22: error: passing argument 1 of 'media_pipeline_stop' from incompatible pointer type [-Werror=incompatible-pointer-types]
1003 | media_pipeline_stop(&q->vdev.entity);
| ^~~~~~~~~~~~~~~
| |
| struct media_entity *
In file included from include/media/media-device.h:18,
from include/media/media-request.h:20,
from include/media/v4l2-ctrls.h:14,
from drivers/media/pci/intel/ipu3/ipu3-cio2.c:23:
include/media/media-entity.h:972:44: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
972 | void media_pipeline_stop(struct media_pad *pad);
| ~~~~~~~~~~~~~~~~~~^~~
drivers/media/pci/intel/ipu3/ipu3-cio2.c: In function 'cio2_vb2_stop_streaming':
drivers/media/pci/intel/ipu3/ipu3-cio2.c:1024:22: error: passing argument 1 of 'media_pipeline_stop' from incompatible pointer type [-Werror=incompatible-pointer-types]
1024 | media_pipeline_stop(&q->vdev.entity);
| ^~~~~~~~~~~~~~~
| |
| struct media_entity *
In file included from include/media/media-device.h:18,
from include/media/media-request.h:20,
from include/media/v4l2-ctrls.h:14,
from drivers/media/pci/intel/ipu3/ipu3-cio2.c:23:
include/media/media-entity.h:972:44: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
972 | void media_pipeline_stop(struct media_pad *pad);
| ~~~~~~~~~~~~~~~~~~^~~
cc1: some warnings being treated as errors


vim +/media_pipeline_start +983 drivers/media/pci/intel/ipu3/ipu3-cio2.c

c2a6a07afe4a46 Yong Zhi 2017-11-08 966
c2a6a07afe4a46 Yong Zhi 2017-11-08 967 static int cio2_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
c2a6a07afe4a46 Yong Zhi 2017-11-08 968 {
c2a6a07afe4a46 Yong Zhi 2017-11-08 969 struct cio2_queue *q = vb2q_to_cio2_queue(vq);
c2a6a07afe4a46 Yong Zhi 2017-11-08 970 struct cio2_device *cio2 = vb2_get_drv_priv(vq);
c2a6a07afe4a46 Yong Zhi 2017-11-08 971 int r;
c2a6a07afe4a46 Yong Zhi 2017-11-08 972
c2a6a07afe4a46 Yong Zhi 2017-11-08 973 cio2->cur_queue = q;
c2a6a07afe4a46 Yong Zhi 2017-11-08 974 atomic_set(&q->frame_sequence, 0);
c2a6a07afe4a46 Yong Zhi 2017-11-08 975
c2a6a07afe4a46 Yong Zhi 2017-11-08 976 r = pm_runtime_get_sync(&cio2->pci_dev->dev);
c2a6a07afe4a46 Yong Zhi 2017-11-08 977 if (r < 0) {
c2a6a07afe4a46 Yong Zhi 2017-11-08 978 dev_info(&cio2->pci_dev->dev, "failed to set power %d\n", r);
c2a6a07afe4a46 Yong Zhi 2017-11-08 979 pm_runtime_put_noidle(&cio2->pci_dev->dev);
c2a6a07afe4a46 Yong Zhi 2017-11-08 980 return r;
c2a6a07afe4a46 Yong Zhi 2017-11-08 981 }
c2a6a07afe4a46 Yong Zhi 2017-11-08 982
c2a6a07afe4a46 Yong Zhi 2017-11-08 @983 r = media_pipeline_start(&q->vdev.entity, &q->pipe);
c2a6a07afe4a46 Yong Zhi 2017-11-08 984 if (r)
c2a6a07afe4a46 Yong Zhi 2017-11-08 985 goto fail_pipeline;
c2a6a07afe4a46 Yong Zhi 2017-11-08 986
c2a6a07afe4a46 Yong Zhi 2017-11-08 987 r = cio2_hw_init(cio2, q);
c2a6a07afe4a46 Yong Zhi 2017-11-08 988 if (r)
c2a6a07afe4a46 Yong Zhi 2017-11-08 989 goto fail_hw;
c2a6a07afe4a46 Yong Zhi 2017-11-08 990
c2a6a07afe4a46 Yong Zhi 2017-11-08 991 /* Start streaming on sensor */
c2a6a07afe4a46 Yong Zhi 2017-11-08 992 r = v4l2_subdev_call(q->sensor, video, s_stream, 1);
c2a6a07afe4a46 Yong Zhi 2017-11-08 993 if (r)
c2a6a07afe4a46 Yong Zhi 2017-11-08 994 goto fail_csi2_subdev;
c2a6a07afe4a46 Yong Zhi 2017-11-08 995
c2a6a07afe4a46 Yong Zhi 2017-11-08 996 cio2->streaming = true;
c2a6a07afe4a46 Yong Zhi 2017-11-08 997
c2a6a07afe4a46 Yong Zhi 2017-11-08 998 return 0;
c2a6a07afe4a46 Yong Zhi 2017-11-08 999
c2a6a07afe4a46 Yong Zhi 2017-11-08 1000 fail_csi2_subdev:
c2a6a07afe4a46 Yong Zhi 2017-11-08 1001 cio2_hw_exit(cio2, q);
c2a6a07afe4a46 Yong Zhi 2017-11-08 1002 fail_hw:
c2a6a07afe4a46 Yong Zhi 2017-11-08 @1003 media_pipeline_stop(&q->vdev.entity);
c2a6a07afe4a46 Yong Zhi 2017-11-08 1004 fail_pipeline:
c2a6a07afe4a46 Yong Zhi 2017-11-08 1005 dev_dbg(&cio2->pci_dev->dev, "failed to start streaming (%d)\n", r);
dcd80955a0a13d Yong Zhi 2018-01-03 1006 cio2_vb2_return_all_buffers(q, VB2_BUF_STATE_QUEUED);
c2a6a07afe4a46 Yong Zhi 2017-11-08 1007 pm_runtime_put(&cio2->pci_dev->dev);
c2a6a07afe4a46 Yong Zhi 2017-11-08 1008
c2a6a07afe4a46 Yong Zhi 2017-11-08 1009 return r;
c2a6a07afe4a46 Yong Zhi 2017-11-08 1010 }
c2a6a07afe4a46 Yong Zhi 2017-11-08 1011

:::::: The code at line 983 was first introduced by commit
:::::: c2a6a07afe4a466896c250cbb203657162b86f4b media: intel-ipu3: cio2: add new MIPI-CSI2 driver

:::::: TO: Yong Zhi <yong.zhi@xxxxxxxxx>
:::::: CC: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip