Re: [PATCH v2] f2fs: compress: disallow disabling compress on non-empty compressed file

[Chao Yu]

On 2021/10/27 12:16, Hyeong-Jun Kim wrote:
> Compresse file and normal file has differ in i_addr addressing,
> specifically addrs per inode/block. So, we will face data loss, if we
> disable the compression flag on non-empty files. Therefore we should
> disallow not only enabling but disabling the compression flag on
> non-empty files.
>
> ---
> v2:
>   - check F2FS_HAS_BLOCKS() instead of i_size
>
> Fixes: 4c8ff7095bef ("f2fs: support data compression")
> Signed-off-by: Sungjong Seo <sj1557.seo@xxxxxxxxxxx>
> Signed-off-by: Hyeong-Jun Kim <hj514.kim@xxxxxxxxxxx>

Reviewed-by: Chao Yu <chao@xxxxxxxxxx>

Thanks,