Re: [PATCH v4 7/8] tracing/selftests: Add tests for hist trigger expression parsing

[Kalesh Singh]

On Tue, Oct 26, 2021 at 8:14 PM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> Hi Kalesh,
>
> On Tue, 26 Oct 2021 18:15:34 -0700
> Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote:
>
> > On Tue, Oct 26, 2021 at 5:20 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > >
> > > On Tue, 26 Oct 2021 16:36:03 -0700
> > > Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote:
> > >
> > > > On my setup I without any of the changes applied (config hist triggers enabled):
> > > >
> > > > ./ftracetests
> > > >
> > > > # of passed:  41
> > > > # of failed:  40
> > > > # of unresolved:  0
> > > > # of untested:  0
> > > > # of unsupported:  32
> > > > # of xfailed:  0
> > > > # of undefined(test bug):  0
> > > >
> > > > Do all the tests pass for you, before any of the changes in this
> > > > series? Maybe some of the tests need updating?
> > >
> > > All my tests past, and I don't push any code if they fail.
> > >
> > > I'd like to understand why you have these failures. Are the test from
> > > the kernel you are testing?
> >
> > The results are from the kernel before I apply any of the patches. I
> > am testing on an Android emulator (cuttlefish) with 5.15.0-rc6 kernel.
> > The tests clearly work so it must be something on my end. I'll
> > investigate and get back to you.
>
> Interesting. There should be test logs under logs/ directory in the
> ftracetest. Can you share the logs/*/ftracetest.log and your kernel kconfig?
>
> Thank you,
>
Hi Masami,

I have attached the config and ftracetest.log here.

Thanks,
Kalesh
>
> --
> Masami Hiramatsu <mhiramat@xxxxxxxxxx>
Tue Oct 26 21:11:37 PDT 2021
=== Ftrace unit tests ===
[1] Basic trace file check	[PASS]
[2] Basic test for tracers	[PASS]
[3] Basic trace clock test	[PASS]
[4] Basic event tracing check	[PASS]
[5] Change the ringbuffer size	[PASS]
[6] Snapshot and tracing setting	[UNSUPPORTED]
[7] trace_pipe and trace_marker	[PASS]
[8] Test ftrace direct functions against tracers	[PASS]
[9] Test ftrace direct functions against kprobes	[PASS]
[10] Generic dynamic event - add/remove eprobe events	[UNSUPPORTED]
[11] Generic dynamic event - add/remove kprobe events	[FAIL]
[12] Generic dynamic event - add/remove synthetic events	[PASS]
[13] Generic dynamic event - selective clear (compatibility)	[FAIL]
[14] Generic dynamic event - generic clear event	[FAIL]
[15] Generic dynamic event - check if duplicate events are caught	[FAIL]
[16] event tracing - enable/disable with event level files	[PASS]
[17] event tracing - restricts events based on pid notrace filtering	[PASS]
[18] event tracing - restricts events based on pid	[PASS]
[19] event tracing - enable/disable with subsystem level files	[PASS]
[20] event tracing - enable/disable with top level files	[PASS]
[21] Test trace_printk from module	[PASS]
[22] ftrace - function graph filters with stack tracer	[UNSUPPORTED]
[23] ftrace - function graph filters	[UNSUPPORTED]
[24] ftrace - function glob filters	[UNSUPPORTED]
[25] ftrace - function pid notrace filters	[UNSUPPORTED]
[26] ftrace - function pid filters	[UNSUPPORTED]
[27] ftrace - stacktrace filter command	[UNSUPPORTED]
[28] ftrace - function trace with cpumask	[UNSUPPORTED]
[29] ftrace - test for function event triggers	[UNSUPPORTED]
[30] ftrace - function trace on module	[UNSUPPORTED]
[31] ftrace - function profiling	[UNSUPPORTED]
[32] ftrace - function profiler with function tracing	[UNSUPPORTED]
[33] ftrace - test reading of set_ftrace_filter	[UNSUPPORTED]
[34] ftrace - Max stack tracer	[UNSUPPORTED]
[35] ftrace - test for function traceon/off triggers	[UNSUPPORTED]
[36] ftrace - test tracing error log support	[PASS]
[37] Test creation and deletion of trace instances while setting an event	[PASS]
[38] Test creation and deletion of trace instances	[PASS]
[39] Kprobe dynamic event - adding and removing	[FAIL]
[40] Kprobe dynamic event - busy event check	[FAIL]
[41] Kprobe dynamic event with arguments	[FAIL]
[42] Kprobe event with comm arguments	[FAIL]
[43] Kprobe event string type argument	[FAIL]
[44] Kprobe event symbol argument	[FAIL]
[45] Kprobe event argument syntax	[PASS]
[46] Kprobes event arguments with types	[FAIL]
[47] Kprobe event user-memory access	[PASS]
[48] Kprobe event auto/manual naming	[PASS]
[49] Kprobe dynamic event with function tracer	[UNSUPPORTED]
[50] Kprobe dynamic event - probing module	[PASS]
[51] Create/delete multiprobe on kprobe event	[FAIL]
[52] Kprobe event parser error log check	[FAIL]
[53] Kretprobe dynamic event with arguments	[FAIL]
[54] Kretprobe dynamic event with maxactive	[PASS]
[55] Kretprobe %return suffix test	[PASS]
[56] Register/unregister many kprobe events	[PASS]
[57] Kprobe events - probe points	[FAIL]
[58] Kprobe dynamic event - adding and removing	[FAIL]
[59] Uprobe event parser error log check	[PASS]
[60] test for the preemptirqsoff tracer	[UNSUPPORTED]
[61] Meta-selftest: Checkbashisms	[PASS]
[62] Test wakeup tracer	[UNSUPPORTED]
[63] Test wakeup RT tracer	[UNSUPPORTED]
[64] event trigger - test inter-event histogram trigger expected fail actions	[UNSUPPORTED]
[65] event trigger - test field variable support	[FAIL]
[66] event trigger - test inter-event combined histogram trigger	[FAIL]
[67] event trigger - test multiple actions on hist trigger	[PASS]
[68] event trigger - test inter-event histogram trigger onchange action	[FAIL]
[69] event trigger - test inter-event histogram trigger onmatch action	[FAIL]
[70] event trigger - test inter-event histogram trigger onmatch-onmax action	[FAIL]
[71] event trigger - test inter-event histogram trigger onmax action	[FAIL]
[72] event trigger - test inter-event histogram trigger snapshot action	[UNSUPPORTED]
[73] event trigger - test inter-event histogram trigger eprobe on synthetic event	[UNSUPPORTED]
[74] event trigger - test synthetic event create remove	[PASS]
[75] event trigger - test inter-event histogram trigger trace action with dynamic string param	[FAIL]
[76] event trigger - test synthetic_events syntax parser	[PASS]
[77] event trigger - test synthetic_events syntax parser errors	[PASS]
[78] event trigger - test inter-event histogram trigger trace action	[FAIL]
[79] event trigger - test event enable/disable trigger	[PASS]
[80] event trigger - test trigger filter	[PASS]
[81] event trigger - test histogram expression parsing	[FAIL]
[82] event trigger - test histogram modifiers	[FAIL]
[83] event trigger - test histogram parser errors	[PASS]
[84] event trigger - test histogram trigger	[PASS]
[85] event trigger - test multiple histogram triggers	[PASS]
[86] event trigger - test snapshot-trigger	[UNSUPPORTED]
[87] event trigger - test stacktrace-trigger	[PASS]
[88] trace_marker trigger - test histogram trigger	[PASS]
[89] trace_marker trigger - test snapshot trigger	[UNSUPPORTED]
[90] trace_marker trigger - test histogram with synthetic event against kernel event	[PASS]
[91] trace_marker trigger - test histogram with synthetic event	[PASS]
[92] event trigger - test traceon/off trigger	[PASS]
[93] (instance)  Basic test for tracers	[PASS]
[94] (instance)  Basic trace clock test	[PASS]
[95] (instance)  Change the ringbuffer size	[PASS]
[96] (instance)  Snapshot and tracing setting	[UNSUPPORTED]
[97] (instance)  trace_pipe and trace_marker	[PASS]
[98] (instance)  event tracing - enable/disable with event level files	[PASS]
[99] (instance)  event tracing - restricts events based on pid notrace filtering	[PASS]
[100] (instance)  event tracing - restricts events based on pid	[PASS]
[101] (instance)  event tracing - enable/disable with subsystem level files	[PASS]
[102] (instance)  ftrace - function pid notrace filters	[UNSUPPORTED]
[103] (instance)  ftrace - function pid filters	[UNSUPPORTED]
[104] (instance)  ftrace - stacktrace filter command	[UNSUPPORTED]
[105] (instance)  ftrace - test for function event triggers	[UNSUPPORTED]
[106] (instance)  ftrace - test for function traceon/off triggers	[UNSUPPORTED]
[107] (instance)  event trigger - test event enable/disable trigger	[PASS]
[108] (instance)  event trigger - test trigger filter	[PASS]
[109] (instance)  event trigger - test histogram modifiers	[FAIL]
[110] (instance)  event trigger - test histogram trigger	[PASS]
[111] (instance)  event trigger - test multiple histogram triggers	[PASS]
[112] (instance)  trace_marker trigger - test histogram trigger	[PASS]
[113] (instance)  trace_marker trigger - test snapshot trigger	[UNSUPPORTED]

# of passed:  54
# of failed:  27
# of unresolved:  0
# of untested:  0
# of unsupported:  32
# of xfailed:  0
# of undefined(test bug):  0

Attachment: config
Description: Binary data