Re: [PATCH] sched/core: Export pelt_thermal_tp

[Christoph Hellwig]

On Thu, Oct 28, 2021 at 06:18:55PM +0200, Peter Zijlstra wrote:
> > > @@ -36,6 +36,7 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(pelt_rt_tp);
> > >  EXPORT_TRACEPOINT_SYMBOL_GPL(pelt_dl_tp);
> > >  EXPORT_TRACEPOINT_SYMBOL_GPL(pelt_irq_tp);
> > >  EXPORT_TRACEPOINT_SYMBOL_GPL(pelt_se_tp);
> > > +EXPORT_TRACEPOINT_SYMBOL_GPL(pelt_thermal_tp);
> > >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_cpu_capacity_tp);
> > >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_overutilized_tp);
> > >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_util_est_cfs_tp);
> > 
> > ... and while we're at it, all these exports are unused and should
> > be deleted as well.
> 
> This is my concession wrt tracepoints. Actual tracepoints are ABI,
> exports are in-kernel interfaces and are explicitly not ABI.
> 
> This way people can use an external module to get at the tracepoint data
> without having in-tree tracepoints.

All of this makes no sense at all.  These are entirely dead exports.
If you remove them nothing else changes.  Note taht the tracepoints
do have in-kernel callers, so if people thing of them as an ABI you've
got your ABI already with or without the exports.