Re: [PATCH v4 04/11] regulator: Introduce tps68470-regulator driver

From: Mark Brown
Date: Thu Oct 28 2021 - 12:23:57 EST


On Mon, Oct 25, 2021 at 11:41:12AM +0200, Hans de Goede wrote:
> The TPS68470 PMIC provides Clocks, GPIOs and Regulators. At present in
> the kernel the Regulators and Clocks are controlled by an OpRegion
> driver designed to work with power control methods defined in ACPI, but
> some platforms lack those methods, meaning drivers need to be able to
> consume the resources of these chips through the usual frameworks.

This looks good to me, if you fix the issues Andy raised I think it's
good to go.

Attachment: signature.asc
Description: PGP signature