Re: [PATCH v9 0/2] Update ASUS WMI supported boards

From: Andy Shevchenko
Date: Sat Oct 30 2021 - 07:23:02 EST


On Sat, Oct 30, 2021 at 12:17 PM Denis Pauk <pauk.denis@xxxxxxxxx> wrote:
>
> Add support by WMI interface provided by Asus for B550/X570 boards:
> * PRIME X570-PRO,
> * ROG CROSSHAIR VIII HERO
> * ROG CROSSHAIR VIII DARK HERO
> * ROG CROSSHAIR VIII FORMULA
> * ROG STRIX X570-E GAMING
> * ROG STRIX B550-E GAMING
>
> Add support by WMI interface provided by Asus for X370/X470/
> B450/X399 boards:
> * ROG CROSSHAIR VI HERO,
> * PRIME X399-A,
> * PRIME X470-PRO,
> * ROG CROSSHAIR VI EXTREME,
> * ROG CROSSHAIR VI HERO (WI-FI AC),
> * ROG CROSSHAIR VII HERO,
> * ROG CROSSHAIR VII HERO (WI-FI),
> * ROG STRIX B450-E GAMING,
> * ROG STRIX B450-F GAMING,
> * ROG STRIX B450-I GAMING,
> * ROG STRIX X399-E GAMING,
> * ROG STRIX X470-F GAMING,
> * ROG STRIX X470-I GAMING,
> * ROG ZENITH EXTREME,
> * ROG ZENITH EXTREME ALPHA.
>
> @Andy Shevchenko: I have added your changes to asus_wmi_ec_sensors. Have I
> correctly applied changes? Thank you.

Thanks!
Since I have no hardware, you may answer better than me, i.e. if it
works, then you did a great job!

> @Guenter Roeck: I have adeed comments about units in the
> asus_wmi_scale_sensor_value.
>
> I have added ACPI_FREE for results to all case of
> usage wmi_evaluate_method. Is it correct?
>
> Could you please review?

I'll look at it later.

--
With Best Regards,
Andy Shevchenko