Re: [PATCH V3 0/4] zram: fix two races and one zram leak
From: Ming Lei
Date: Sun Oct 31 2021 - 20:28:42 EST
Hello Andrew Morton and Jens,
On Mon, Oct 25, 2021 at 09:30:07AM -0700, Minchan Kim wrote:
> On Mon, Oct 25, 2021 at 10:54:22AM +0800, Ming Lei wrote:
> > Hello,
> >
> > Fixes three issues reported by Luis Chamberlain with one simpler approach:
> >
> > - race between between zram_reset_device() and disksize_store() (1/4)
> >
> > - zram leak during unloading module, which is one race between resetting
> > and removing device (2/4)
> >
> > - race between zram_remove and disksize_store (3/4)
> >
> > Also replace replace fsync_bdev with sync_blockdev since no one opens
> > it.(4/4)
> >
> > V3:
> > - no code change
> > - update commit log or comment as Luis suggested
> > - add reviewed-by tag
> >
> > V2:
> > - take another approach to avoid failing of zram_remove()
> > - add patch to address race between zram_reset_device() and
> > disksize_store()
> >
> >
> > Ming Lei (4):
> > zram: fix race between zram_reset_device() and disksize_store()
> > zram: don't fail to remove zram during unloading module
> > zram: avoid race between zram_remove and disksize_store
> > zram: replace fsync_bdev with sync_blockdev
>
> Andrew Morton usually takes zram patches so Ccing him.
>
> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
>
> for all patches in this thread.
Any chance to make it in v5.16?
Thanks,
Ming