Re: [PATCH v1] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format

[Bjorn Andersson]

On Mon 01 Nov 23:57 PDT 2021, Fenglin Wu wrote:
[..]
> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> new file mode 100644
> index 0000000..05bb114
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> @@ -0,0 +1,122 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spmi/qcom,spmi-pmic-arb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SPMI PMIC Arbiter
> +
> +maintainers:
> +  - Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
> +
> +description: |
> +  The SPMI PMIC Arbiter is found on Snapdragon chipsets. It is an SPMI
> +  controller with wrapping arbitration logic to allow for multiple
> +  on-chip devices to control a single SPMI master.
> +
> +  The PMIC Arbiter can also act as an interrupt controller, providing
> +  interrupts to slave devices.
> +
> +  See Documentation/devicetree/bindings/spmi/spmi.yaml for the generic
> +  SPMI controller binding requirements for child nodes.
> +
> +properties:
> +  $nodename:
> +    pattern: "^qcom,spmi@.*"

Node names should never contain "qcom,". Seems the agreed upon node
named should be "spmi@.*".

The rest looks like a reasonable conversion to me.

[..]
> +examples:
> +  - |
> +    qcom,spmi@fc4cf000 {

Regards,
Bjorn