[allisonhenderson-xfs-work:refs/heads/pptrs_restart130 23/32] fs/xfs/libxfs/xfs_parent.c:55:1: warning: no previous prototype for function 'xfs_init_parent_name_rec'

From: kernel test robot
Date: Thu Nov 04 2021 - 04:34:49 EST


tree: https://github.com/allisonhenderson/xfs_work.git refs/heads/pptrs_restart130
head: 81b586ed999042613d6e120407086764e8ebf095
commit: 4f27c965cd8c551d36aca05595ef584020e12368 [23/32] xfs: parent pointer attribute creation
config: i386-randconfig-a003-20211103 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 847a6807332b13f43704327c2d30103ec0347c77)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/allisonhenderson/xfs_work/commit/4f27c965cd8c551d36aca05595ef584020e12368
git remote add allisonhenderson-xfs-work https://github.com/allisonhenderson/xfs_work.git
git fetch --no-tags allisonhenderson-xfs-work refs/heads/pptrs_restart130
git checkout 4f27c965cd8c551d36aca05595ef584020e12368
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> fs/xfs/libxfs/xfs_parent.c:55:1: warning: no previous prototype for function 'xfs_init_parent_name_rec' [-Wmissing-prototypes]
xfs_init_parent_name_rec(
^
fs/xfs/libxfs/xfs_parent.c:54:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void
^
static
>> fs/xfs/libxfs/xfs_parent.c:70:1: warning: no previous prototype for function 'xfs_init_parent_name_irec' [-Wmissing-prototypes]
xfs_init_parent_name_irec(
^
fs/xfs/libxfs/xfs_parent.c:69:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void
^
static
2 warnings generated.


vim +/xfs_init_parent_name_rec +55 fs/xfs/libxfs/xfs_parent.c

35
36 /*
37 * Parent pointer attribute handling.
38 *
39 * Because the attribute value is a filename component, it will never be longer
40 * than 255 bytes. This means the attribute will always be a local format
41 * attribute as it is xfs_attr_leaf_entsize_local_max() for v5 filesystems will
42 * always be larger than this (max is 75% of block size).
43 *
44 * Creating a new parent attribute will always create a new attribute - there
45 * should never, ever be an existing attribute in the tree for a new inode.
46 * ENOSPC behavior is problematic - creating the inode without the parent
47 * pointer is effectively a corruption, so we allow parent attribute creation
48 * to dip into the reserve block pool to avoid unexpected ENOSPC errors from
49 * occurring.
50 */
51
52
53 /* Initializes a xfs_parent_name_rec to be stored as an attribute name */
54 void
> 55 xfs_init_parent_name_rec(
56 struct xfs_parent_name_rec *rec,
57 struct xfs_inode *ip,
58 uint32_t p_diroffset)
59 {
60 xfs_ino_t p_ino = ip->i_ino;
61 uint32_t p_gen = VFS_I(ip)->i_generation;
62
63 rec->p_ino = cpu_to_be64(p_ino);
64 rec->p_gen = cpu_to_be32(p_gen);
65 rec->p_diroffset = cpu_to_be32(p_diroffset);
66 }
67
68 /* Initializes a xfs_parent_name_irec from an xfs_parent_name_rec */
69 void
> 70 xfs_init_parent_name_irec(

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip