Re: [RFC PATCH 1/5] firmware: Create firmware upload framework

[Russ Weight]

On 11/17/21 7:15 AM, Greg KH wrote:
> On Wed, Nov 10, 2021 at 05:13:41PM -0800, Russ Weight wrote:
>> The Firmware Upload class driver provides a common API for uploading
>> firmware files to devices.
> That is exactly what the existing firmware api in the kernel is supposed
> to be accomplishing.
>
> If it is not doing what you need it to do, then you need to document the
> heck out of why it is not, and why you need a different api for this.  I
> do not see that here in this changelog at all :(
This is part of the documentation included later in this patch. I can add
this to the changelog.

+Some devices load firmware from on-board FLASH when the card initializes.
+These cards do not require the request_firmware framework to load the
+firmware when the card boots, but they to require a utility to allow
+users to update the FLASH contents.

When you say "existing firmware api", I'm thinking request_firmware, which
requires that driver names be specified in the kernel config and wants to
load firmware automatically during device initialization.

Other support under driver/firmware is specific to certain vendors, devices.

If I add this information to the changelog, is that sufficient?

> thanks,
>
> greg k-h