Re: [PATCH] staging: vt6655: rename variable bHWRadioOff

From: Tommaso Merciai
Date: Tue Nov 23 2021 - 15:08:50 EST


On Sun, Nov 21, 2021 at 12:19:59PM +0100, Alberto Merciai wrote:
> Replace camelcase hungarian notated variable "bHWRadioOff"
> into linux kernel coding style equivalent variable "hw_radio_off".
>
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@xxxxxxxxx>
> ---
> drivers/staging/vt6655/device.h | 2 +-
> drivers/staging/vt6655/device_main.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index ff171acc11f4..e9d1b56d8809 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -229,7 +229,7 @@ struct vnt_private {
> /* GPIO Radio Control */
> unsigned char byRadioCtl;
> unsigned char byGPIO;
> - bool bHWRadioOff;
> + bool hw_radio_off;
> bool bPrvActive4RadioOFF;
> bool bGPIOBlockRead;
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 1f98f2b069c4..897d70cf32b8 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -373,7 +373,7 @@ static void device_init_registers(struct vnt_private *priv)
>
> priv->byRadioCtl = SROMbyReadEmbedded(priv->port_offset,
> EEP_OFS_RADIOCTL);
> - priv->bHWRadioOff = false;
> + priv->hw_radio_off = false;
>
> if (priv->byRadioCtl & EEP_RADIOCTL_ENABLE) {
> /* Get GPIO */
> @@ -383,10 +383,10 @@ static void device_init_registers(struct vnt_private *priv)
> !(priv->byRadioCtl & EEP_RADIOCTL_INV)) ||
> (!(priv->byGPIO & GPIO0_DATA) &&
> (priv->byRadioCtl & EEP_RADIOCTL_INV)))
> - priv->bHWRadioOff = true;
> + priv->hw_radio_off = true;
> }
>
> - if (priv->bHWRadioOff || priv->bRadioControlOff)
> + if (priv->hw_radio_off || priv->bRadioControlOff)
> CARDbRadioPowerOff(priv);
>
> /* get Permanent network address */
> --
> 2.25.1
>

Look's okay.

Acked-by: Tommaso Merciai <tommaso.merciai@xxxxxxxxx>

Regards,
Tommaso