Re: [PATCH v2 2/4] mm/vmalloc: add support for __GFP_NOFAIL

From: Michal Hocko
Date: Tue Nov 23 2021 - 15:09:46 EST

On Tue 23-11-21 20:01:50, Uladzislau Rezki wrote:
> I have raised two concerns in our previous discussion about this change,
> well that is sad...

I definitely didn't mean to ignore any of the feedback. IIRC we were in
a disagreement in the failure mode for retry loop - i.e. free all the
allocated pages in case page table pages cannot be allocated. I still
maintain my position and until there is a wider consensus on that I will
keep my current implementation. The other concern was about failures
warning but that shouldn't be a problem when basing on the current Linus
tree. Am I missing something?
Michal Hocko