Re: spinlock.c:306:9: error: implicit declaration of function '__raw_write_lock_nested'

[Arnd Bergmann]

On Wed, Nov 24, 2021 at 8:31 AM Rob Landley <rob@xxxxxxxxxxx> wrote:
> On 11/23/21 5:38 AM, Naresh Kamboju wrote:
>
> diff --git a/arch/sh/kernel/syscalls/syscall.tbl
> b/arch/sh/kernel/syscalls/syscall.tbl
> index 208f131659c5..65c3a94bff48 100644
> --- a/arch/sh/kernel/syscalls/syscall.tbl
> +++ b/arch/sh/kernel/syscalls/syscall.tbl
> @@ -437,7 +437,7 @@
>  432    common  fsmount                         sys_fsmount
>  433    common  fspick                          sys_fspick
>  434    common  pidfd_open                      sys_pidfd_open
> -# 435 reserved for clone3
> +435    common  clone3                          sys_clone3
>  436    common  close_range                     sys_close_range
>  437    common  openat2                         sys_openat2
>  438    common  pidfd_getfd                     sys_pidfd_getfd

Did you test clone3? This needs a custom wrapper on most architectures
to have sensible calling conventions. If sh doesn't need it, that should
be explained in the changelog text.

> @@ -451,3 +451,4 @@
>  446    common  landlock_restrict_self          sys_landlock_restrict_self
>  # 447 reserved for memfd_secret
>  448    common  process_mrelease                sys_process_mrelease
> +449    common  futex_waitv                     sys_futex_waitv

I don't know what's going on with this one, I don't actually see
a reason why it isn't already wired up on all architectures. If we add
this, it should probably be done for all architectures at once as a
bugfix, but it's possible that this is intentionally only used on
x86 and arm.

André, can you comment on this?

      Arnd