Re: [PATCH v4 0/3] device property: Remove device_add_properties()
From: Rafael J. Wysocki
Date: Wed Nov 24 2021 - 09:31:12 EST
On Wed, Nov 24, 2021 at 3:15 PM Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 24, 2021 at 02:59:01PM +0100, Rafael J. Wysocki wrote:
> > On Mon, Nov 15, 2021 at 1:10 PM Heikki Krogerus
> > <heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> > >
> > > Hi,
> > >
> > > One more version. Hopefully the commit messages are now OK. No other
> > > changes since v3:
> > >
> > > https://lore.kernel.org/lkml/20211006112643.77684-1-heikki.krogerus@xxxxxxxxxxxxxxx/
> > >
> > >
> > > v3 cover letter:
> > >
> > > In this third version of this series, the second patch is now split in
> > > two. The device_remove_properties() call is first removed from
> > > device_del() in its own patch, and the
> > > device_add/remove_properties() API is removed separately in the last
> > > patch. I hope the commit messages are clear enough this time.
> > >
> > >
> > > v2 cover letter:
> > >
> > > This is the second version where I only modified the commit message of
> > > the first patch according to comments from Bjorn.
> > >
> > >
> > > Original cover letter:
> > >
> > > There is one user left for the API, so converting that to use software
> > > node API instead, and removing the function.
> > >
> > >
> > > thanks,
> > >
> > > Heikki Krogerus (3):
> > > PCI: Convert to device_create_managed_software_node()
> > > driver core: Don't call device_remove_properties() from device_del()
> > > device property: Remove device_add_properties() API
> > >
> > > drivers/base/core.c | 1 -
> > > drivers/base/property.c | 48 ----------------------------------------
> > > drivers/pci/quirks.c | 2 +-
> > > include/linux/property.h | 4 ----
> > > 4 files changed, 1 insertion(+), 54 deletions(-)
> >
> > Has this been picked up already or am I expected to pick it up?
>
> It hasn't been picked up by anybody, so if you can take these, that
> would be great.
OK, applied as 5.17 material now.
Greg, please let me know if you'd rather take these patches yourself
and I'll drop them in that case.
Thanks!