Re: [PATCH] staging: r8188eu: use max() and min() macros

From: Vihas Mak
Date: Wed Nov 24 2021 - 09:56:57 EST


>> Please run scripts/checkpatch.pl on your patches.

>> CHECK: Alignment should match open parenthesis
>> #41: FILE: drivers/staging/r8188eu/core/rtw_wlan_util.c:723:

Ahh sorry, my bad. Will resend v2 after fixing that.

On Wed, Nov 24, 2021 at 6:44 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> On Wed, Nov 24, 2021 at 04:55:51AM +0530, Vihas Mak wrote:
>
> > +
> > + min_MPDU_spacing = max(pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x1c,
> > + pIE->data[i] & 0x1c);
>
> Please run scripts/checkpatch.pl on your patches.
>
> CHECK: Alignment should match open parenthesis
> #41: FILE: drivers/staging/r8188eu/core/rtw_wlan_util.c:723:
> + min_MPDU_spacing = max(pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x1c,
> + pIE->data[i] & 0x1c);
>
> regards,
> dan carpenter
>


--
Thanks,
Vihas