Re: [PATCH] tools/thermal: remove unneeded variable

[Rafael J. Wysocki]

On Fri, Nov 12, 2021 at 10:09 AM <cgel.zte@xxxxxxxxx> wrote:
>
> From: ran jianping <ran.jianping@xxxxxxxxxx>
>
> Fix the following coccicheck review:
> /tools/thermal/tmon/pid.c:57:5-8: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: ran jianping <ran.jianping@xxxxxxxxxx>
> ---
>  tools/thermal/tmon/pid.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/thermal/tmon/pid.c b/tools/thermal/tmon/pid.c
> index c54edb4f630c..296f69c00c57 100644
> --- a/tools/thermal/tmon/pid.c
> +++ b/tools/thermal/tmon/pid.c
> @@ -54,7 +54,6 @@ static double xk_1, xk_2; /* input temperature x[k-#] */
>   */
>  int init_thermal_controller(void)
>  {
> -       int ret = 0;
>
>         /* init pid params */
>         p_param.ts = ticktime;
> @@ -65,7 +64,7 @@ int init_thermal_controller(void)
>
>         p_param.t_target = target_temp_user;
>
> -       return ret;
> +       return 0;
>  }
>
>  void controller_reset(void)
> --

Applied as 5.17 material, thanks!