Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode

[Steven Rostedt]

On Wed, 24 Nov 2021 17:12:12 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> > +	/*
> > +	 * Set the size of the bucket.
> > +	 */
> > +	bucket_size = params->output_divisor * params->bucket_size;
> > +	snprintf(buff, sizeof(buff), "duration.buckets=%d", bucket_size);
> > +
> > +	data->trace_hist = tracefs_hist_alloc(tool->trace.tep, "osnoise", "sample_threshold",
> > +			buff, TRACEFS_HIST_KEY_NORMAL);  
> 
> FYI, we changed the API (haven't tagged it yet, so we can do that :-) and
> the above needs to be:
> 
> 	data->trace_hist = tracefs_hist1d_alloc(tool->trace.tep, "osnoise", "sample_threshold",

Or do you think that 1d should be the default, and we have:

	tracefs_hist_alloc()	-- 1d histogram
	tracefs_hist_alloc_2d()	-- 2d histogram
	tracefs_hist_alloc_nd()	-- Nd histogram?

??

We haven't tagged it yet, so we could change it again (and then your code
will work as is).

-- Steve