Re: [PATCH] media: i2c: dw9714: add optional regulator support

From: Mark Brown
Date: Thu Nov 25 2021 - 06:50:26 EST


On Thu, Nov 25, 2021 at 09:09:22AM +0100, Martin Kepplinger wrote:

> + dw9714_dev->vcc = devm_regulator_get_optional(&client->dev, "vcc");
> + if (IS_ERR(dw9714_dev->vcc)) {
> + if (PTR_ERR(dw9714_dev->vcc) != -ENODEV)

This looks like an abuse of regulator_get_optiona(), unless the supply
might be physically absent in a system it should be using a normal
regulator_get().

Attachment: signature.asc
Description: PGP signature