Re: [RESEND PATCH 1/1] perf arm-spe: report all SPE records as "all" events

[German Gomez]

Hi Leo,

On 25/11/2021 07:53, Leo Yan wrote:
> On Wed, Nov 17, 2021 at 02:28:32PM +0000, German Gomez wrote:
>> [...]
> After checked the event types, I think "other" samples would include
> below raw event types:
>
>   EV_EXCEPTION_GEN
>   EV_RETIRED
>   EV_NOT_TAKEN
>   EV_ALIGNMENT
>   EV_PARTIAL_PREDICATE
>   EV_EMPTY_PREDICATE
>
> I am just wander if we can use sample.transaction to store these event
> types, otherwise, we cannot distinguish the event type for the samples.

I'm not familiar with the meaning of transactions in this context, but
I agree giving visibility of these remaining events is a good idea. I'm
just unsure where to place them from the available --itrace options.

Regarding the "all" events, we thought having quick access to a  global
histogram of all the spe events is useful, and from all the --itrace
options it seemed to fit best under --itrace=o.

Thanks,
German

>
> And it's good fill more sample fields for complete info, like:
>
>   sample.addr = record->virt_addr;
>   sample.phys_addr = record->phys_addr;
>   sample.data_src = data_src;
>
> Thanks,
> Leo
>
>> [...]