Re: [RFC PATCH v3 29/59] KVM: x86: Add option to force LAPIC expiration wait

From: Thomas Gleixner
Date: Thu Nov 25 2021 - 14:55:29 EST


On Wed, Nov 24 2021 at 16:20, isaku yamahata wrote:
> Add an option to skip the IRR check in kvm_wait_lapic_expire().

Yay for consistency. $Subject says 'Add option to force wait'. Changelog
says 'Add option to skip ... check'. Can you make your mind up?

Also the change at hand is not adding an option. It's adding a function
argument. You surely can spot the difference between option and function
argument, right?

Changelogs are meant to be readable by mere mortals.

Thanks,

tglx