Re: [RFC PATCH v3 46/59] KVM: VMX: Move register caching logic to common code

[Paolo Bonzini]

On 11/25/21 21:11, Thomas Gleixner wrote:
> > Use kvm_x86_ops.cache_reg() in ept_update_paging_mode_cr0() rather than
> > trying to expose vt_cache_reg() to vmx.c, even though it means taking a
> > retpoline.  The code runs if and only if EPT is enabled but unrestricted
> > guest.
> This sentence does not parse because it's not a proper sentence.
>
> > Only one generation of CPU, Nehalem, supports EPT but not
> > unrestricted guest, and disabling unrestricted guest without also
> > disabling EPT is, to put it bluntly, dumb.
> This one is only significantly better and lacks an explanation what this
> means for the dumb case.

Well, it means a retpoline (see paragraph before).  However, I'm not 
sure why it one wouldn't create a vt.h header with all vt_* functions.

Paolo