Re: [PATCH v3 0/4] Add DTs for all Apple M1 (t8103) devices

From: Hector Martin
Date: Fri Nov 26 2021 - 01:53:53 EST


On 26/11/2021 15.33, Janne Grunau wrote:
Hej,

On 2021-11-26 14:39:16 +0900, Hector Martin wrote:
On 23/11/2021 07.58, Janne Grunau wrote:

Janne Grunau (4):
dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings
arm64: dts: apple: Add missing M1 (t8103) devices
arm64: dts: apple: t8103: Add i2c nodes
arm64: dts: apple: t8103: Add cd321x nodes

.../devicetree/bindings/arm/apple.yaml | 6 +-
arch/arm64/boot/dts/apple/Makefile | 4 +
arch/arm64/boot/dts/apple/t8103-j274.dts | 33 +------
arch/arm64/boot/dts/apple/t8103-j293.dts | 41 +++++++++
arch/arm64/boot/dts/apple/t8103-j313.dts | 33 +++++++
arch/arm64/boot/dts/apple/t8103-j456.dts | 59 ++++++++++++
arch/arm64/boot/dts/apple/t8103-j457.dts | 47 ++++++++++
arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 67 ++++++++++++++
arch/arm64/boot/dts/apple/t8103.dtsi | 92 +++++++++++++++++++
9 files changed, 352 insertions(+), 30 deletions(-)
create mode 100644 arch/arm64/boot/dts/apple/t8103-j293.dts
create mode 100644 arch/arm64/boot/dts/apple/t8103-j313.dts
create mode 100644 arch/arm64/boot/dts/apple/t8103-j456.dts
create mode 100644 arch/arm64/boot/dts/apple/t8103-j457.dts
create mode 100644 arch/arm64/boot/dts/apple/t8103-jxxx.dtsi


Whole series is:

Tested-by: Hector Martin <marcan@xxxxxxxxx>

on j274, j313, j456.

Thanks! If you spin up a v4 with the minor comments addressed, I'll be happy
to merge it :)

there is already a v4 with Sven's comments addressed at

https://lore.kernel.org/linux-arm-kernel/20211123224926.7722-1-j@xxxxxxxxxx/

Jean-Marc Ranger notified me off-list of a typo in "arm64: dts: apple:
t8103: Add cd321x nodes" commit messages: 'addiotional'.

I don't think it's worth spinning up a v5 for fixing that typo.

Oh whoops, I think I mixed that one up with this one when scrolling through email and thought they were the same series. Was just catching up on email and it hadn't hit me yet... thanks for pointing it out.

--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub