Re: [PATCH v2] net: dsa: realtek-smi: fix indirect reg access for ports>3

From: Greg KH
Date: Fri Nov 26 2021 - 03:23:10 EST


On Fri, Nov 26, 2021 at 05:12:52AM -0300, luizluca@xxxxxxxxx wrote:
> From: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>
>
> This switch family can have up to 8 ports {0..7}. However,
> INDIRECT_ACCESS_ADDRESS_PHYNUM_MASK was using 2 bits instead of 3,
> dropping the most significant bit during indirect register reads and
> writes. Reading or writing ports 4, 5, 6, and 7 registers was actually
> manipulating, respectively, ports 0, 1, 2, and 3 registers.
>
> rtl8365mb_phy_{read,write} will now returns -EINVAL if phy is greater
> than 7.
>
> v2:
> - fix affected ports in commit message
>
> Fixes: 4af2950c50c8 ("net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC")
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>
> ---
> drivers/net/dsa/rtl8365mb.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>