Re: [PATCH v1 00/10] misc: at25: Code cleanups and improvements

[Andy Shevchenko]

On Thu, Nov 25, 2021 at 11:03:26PM +0100, Arnd Bergmann wrote:
> On Thu, Nov 25, 2021 at 10:31 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > Code cleanups and improvements. Please read individual commit messages.
> >
> > Series depends on the fixes series [1] sent earlier.
> >
> > [1]: https://lore.kernel.org/lkml/20211125212729.86585-2-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u
> >
> > Andy Shevchenko (10):
> >   misc: at25: Use at25->chip instead of local chip everywhere in
> >     ->probe()
> >   misc: at25: Unshadow error codes in at25_fw_to_chip()
> >   misc: at25: Check new property ("address-width") first
> >   misc: at25: Get platform data via dev_get_platdata()
> >   misc: at25: Get rid of intermediate storage for AT25 chip data
> >   misc: at25: Switch to use BIT() instead of custom approaches
> >   misc: at25: Factor out at_fram_to_chip()
> >   misc: at25: Reorganize headers for better maintenance
> >   misc: at25: Replace commas by spaces in the ID tables
> >   misc: at25: Align comment style
> 
> These also look good to me,
> 
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

Thank you!

> It would be nice to change the three remaining board files that fill
> struct spi_eeprom so they use device properties and unify the
> rest of the probe path. Not sure how much of a change that would
> be.

Do you have a chance to test that if it appears to be the case?

-- 
With Best Regards,
Andy Shevchenko