Re: [PATCH v1 1/1] MIPS: TXx9: Convert SPI platform data to software nodes

[Geert Uytterhoeven]

Hi Arnd,

On Fri, Nov 26, 2021 at 11:58 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Fri, Nov 26, 2021 at 11:23 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > In order to get rid of legacy platform data in AT25 driver,
> > convert its users to use software nodes.
> >
> > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> This looks good to me, thanks for cleaning this up! I think Geert has this
> hardware, adding him to Cc in case he wants to give it a spin.

The SPI controller is only present on TX4938, not on TX4927, so it is
unused on my rbtx4927 board.

> >  arch/mips/include/asm/txx9/spi.h    |  4 ++--
> >  arch/mips/txx9/generic/spi_eeprom.c | 32 +++++++++++++++++------------
> >  arch/mips/txx9/rbtx4938/setup.c     |  6 +++---
> >  3 files changed, 24 insertions(+), 18 deletions(-)

Probably all of this can be removed, given the SPI controller driver
itself was removed in commit 74523a5dae0c96d6 ("spi: txx9: Remove
driver")?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds