Re: esp_scsi.c:undefined reference to `scsi_done'

[Bart Van Assche]

On 11/25/21 04:18, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   5f53fa508db098c9d372423a6dac31c8a5679cdf
> commit: f8ab27d9649440a4fa6e77bbea939a62fd44df27 scsi: esp_scsi: Call scsi_done() directly
> date:   6 weeks ago
> config: mips-buildonly-randconfig-r002-20211124 (https://download.01.org/0day-ci/archive/20211125/202111252028.JcclVVMH-lkp@xxxxxxxxx/config)
> compiler: mips64-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f8ab27d9649440a4fa6e77bbea939a62fd44df27
>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>          git fetch --no-tags linus master
>          git checkout f8ab27d9649440a4fa6e77bbea939a62fd44df27
>          # save the config file to linux build tree
>          mkdir build_dir
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
>     mips64-linux-ld: drivers/scsi/esp_scsi.o: in function `esp_setsync':
>     esp_scsi.c:(.text+0xc04): undefined reference to `spi_display_xfer_agreement'

(+Masahiro Yamada)

In the config file mentioned above I found the following:

CONFIG_SCSI_SPI_ATTRS=m
CONFIG_JAZZ_ESP=y

And in drivers/scsi/Kconfig I found the following:

config JAZZ_ESP
	bool "MIPS JAZZ FAS216 SCSI support"
	depends on MACH_JAZZ && SCSI
	select SCSI_SPI_ATTRS
	help
	  [ ... ]

I think this indicates a bug in the kbuild infrastructure: if 
CONFIG_JAZZ_ESP is set to 'y' then CONFIG_SCSI_SPI_ATTRS also should be 
set to 'y'.

Thanks,

Bart.