RE: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable
From: Manish Rangankar
Date: Sat Nov 27 2021 - 04:17:19 EST
> >> list = (u64 *)qedi->bdq_pbl_list;
> >> - page = qedi->bdq_pbl_list_dma;
> >> for (i = 0; i < qedi->bdq_pbl_list_num_entries; i++) {
> >> *list = qedi->bdq_pbl_dma;
> >> list++;
> >> - page += QEDI_PAGE_SIZE;
> >> }
> >>
> >> return 0;
> >> --
> >> 2.25.1
> >
> > Thanks,
> > Acked-by: Manish Rangankar <mrangankar@xxxxxxxxxxx>
>
> Thanks for taking a look, does not that make the loop iterating the list even
> more useless now, though? Should not page have been used for something in
> that function?
> --
We need list to build structure of bdq list in firmware understandable format.