Re: [PATCH v3] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema

From: Rob Herring
Date: Sat Nov 27 2021 - 18:22:17 EST


On Fri, 26 Nov 2021 10:32:28 +0530, Jayesh Choudhary wrote:
> Convert the bindings for McASP controllers for TI SOCs
> from txt to YAML schema.
>
> Adds additional properties 'clocks', 'clock-names', 'power-domains',
> '#sound-dai-cells', 'num-serializer' and 'port' which were not there
> in the txt file.
> Adds 'dmas' and 'dma-names' in the example which were not there in
> the txt file.
> Changes 'interrupts' and 'interrupt-names' from optional to
> required properties.
>
> Signed-off-by: Jayesh Choudhary <j-choudhary@xxxxxx>
> ---
> Changelog:
> v3:
> - removes maxItems from 'clock-names'
>
> v2:
> - changes the commit message
> - modifies the properties 'clocks', 'clock-names', 'dma-names',
> 'dmas', 'interrupts' and 'interrupt-names' according to the
> arm SOCs
> - adds 'port' and 'num-serializer' as node properties
>
> .../bindings/sound/davinci-mcasp-audio.txt | 86 ---------
> .../bindings/sound/davinci-mcasp-audio.yaml | 178 ++++++++++++++++++
> 2 files changed, 178 insertions(+), 86 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt
> create mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
>

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1559951


mcasp@0: 'rt-num-evt' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/am335x-wega-rdk.dt.yaml

mcasp@2b00000: 'op-mode' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml

mcasp@2b00000: 'serial-dir' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml

mcasp@2b00000: 'tdm-slots' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml

mcasp@2b10000: 'op-mode' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml

mcasp@2b10000: 'serial-dir' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml

mcasp@2b10000: 'tdm-slots' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml

mcasp@2b20000: 'op-mode' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml

mcasp@2b20000: 'serial-dir' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml

mcasp@2b20000: 'tdm-slots' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml