RE: [PATCH] mei: Remove some dead code

[Winkler, Tomas]

> On Sun, Nov 28, 2021 at 11:12:33AM +0000, Winkler, Tomas wrote:
> >
> > >
> > >
> > > > On 12 Nov 2021, at 11:06, Christophe JAILLET
> > > <christophe.jaillet@xxxxxxxxxx> wrote:
> > > >
> > > > 'generated' is known to be true here, so "true || whatever" will
> > > > still be true.
> > > >
> > > > So, remove some dead code.
> > > >
> > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> > > > ---
> > > > This is also likely that a bug is lurking here.
> > > >
> > > > Maybe, the following was expected:
> > > > -	generated = generated ||
> > > > +	generated =
> > > > 		(hisr & HISR_INT_STS_MSK) ||
> > > > 		(ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
> > > >
> > > > ?
> > >
> > > I concur about your analysis, but I do not know the intent here.
> > Your fix  is okay, I can ack that patch.
> 
> Is that an ack of this patch?  If so, please provide that...
Acked-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
Thanks
Tomas