Re: [PATCH] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build

[Randy Dunlap]

On 11/28/21 13:26, Wei Liu wrote:
> On Sat, Nov 27, 2021 at 07:12:11PM +0000, Michael Kelley (LINUX) wrote:
> > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Sent: Thursday, November 25, 2021 6:33 PM
> > > The hyperv utilities use PTP clock interfaces and should depend a
> > > a kconfig symbol such that they will be built as a loadable module or
> > > builtin so that linker errors do not happen.
> > >
> > > Prevents these build errors:
> > >
> > > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit':
> > > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister'
> > > ld: drivers/hv/hv_util.o: in function `hv_timesync_init':
> > > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register'
> > >
> > > Fixes: 46a971913611a ("Staging: hv: move hyperv code out of staging directory")
> >
> > Seems like the "Fixes" tag should reference something a little newer than
> > when the Hyper-V code was first added.  Either commit 3716a49a81ba
> > ("hv_utils: implement Hyper-V PTP source") or commit e5f31552674e
> > ("ethernet: fix PTP_1588_CLOCK dependencies") when
> > PTP_1588_CLOCK_OPTIONAL was added.
> [...]
> > Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
>
> I used 3716a49a81ba in the Fixes tag and pushed it to hyperv-fixes.
>
> Wei.

Oh, thank you.

~Randy