Re: [PATCH] libertas_tf: Use struct_group() for memcpy() region

From: Kalle Valo
Date: Mon Nov 29 2021 - 05:47:23 EST


Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field array bounds checking for memcpy(), memmove(), and memset(),
> avoid intentionally writing across neighboring fields.
>
> Use struct_group() in struct txpd around members tx_dest_addr_high
> and tx_dest_addr_low so they can be referenced together. This will
> allow memcpy() and sizeof() to more easily reason about sizes, improve
> readability, and avoid future warnings about writing beyond the end
> of tx_dest_addr_high.
>
> "pahole" shows no size nor member offset changes to struct txpd.
> "objdump -d" shows no object code changes.
>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

642a57475b30 libertas_tf: Use struct_group() for memcpy() region

--
https://patchwork.kernel.org/project/linux-wireless/patch/20211118184121.1283821-1-keescook@xxxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches