Re: [PATCH net] net: stmmac: Avoid DMA_CHAN_CONTROL write if no Split Header support

From: patchwork-bot+netdevbpf
Date: Mon Nov 29 2021 - 07:22:19 EST


Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Fri, 26 Nov 2021 16:51:15 +0100 you wrote:
> The driver assumes that split headers can be enabled/disabled without
> stopping/starting the device, so it writes DMA_CHAN_CONTROL from
> stmmac_set_features(). However, on my system (IP v5.10a without Split
> Header support), simply writing DMA_CHAN_CONTROL when DMA is running
> (for example, with the commands below) leads to a TX watchdog timeout.
>
> host$ socat TCP-LISTEN:1024,fork,reuseaddr - &
> device$ ethtool -K eth0 tso off
> device$ ethtool -K eth0 tso on
> device$ dd if=/dev/zero bs=1M count=10 | socat - TCP4:host:1024
> <tx watchdog timeout>
>
> [...]

Here is the summary with links:
- [net] net: stmmac: Avoid DMA_CHAN_CONTROL write if no Split Header support
https://git.kernel.org/netdev/net/c/f8e7dfd6fdab

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html